https://bugzilla.redhat.com/show_bug.cgi?id=2164874 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- The package is APPROVED as-is, although I have a handful of suggestions. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Notes (no change required for approval ===== - Patches no longer need to be numbered unless you are applying selected patches by number. You can just write: Patch: 0001-Require-more_itertools.patch Patch: 0002-Disable-linters.patch - Instead of patching out the linters with 0002-Disable-linters.patch, you might find it easier to simply add: BuildRequires: python3dist(pytest) and drop “-t” from %pyproject_buildrequires, and then run the tests with %pytest instead of %tox. However, the patch is a fine approach as long as it is not too annoying to maintain. If you do keep using the patch, it would be good to add the following comment above it in the spec file as justification: # https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters - Co-ownership of /usr/lib/python3.11/site-packages/jaraco is an appropriate approach for Python namespace packages. However, in this case a package (python3-jaraco) exists solely to provide that directory, so it might be better to depend on it instead: %package -n python3-%{pkgname} […] Requires: python3dist(jaraco) […] %files -n python3-%{pkgname} -f %{pyproject_files} […] # Owned by python3dist(jaraco) %exclude %dir %{python3_sitelib}/jaraco This would be consistent with other existing Jaraco packages (python-jaraco-{classes,collections,envs,functools,path}). - I personally think the indirection of the modname, projname, and pkgname macros makes the specfile harder rather than easier to read, and I would just write out the appropriate strings where they appear. However, this is purely a matter of taste. - Since pyproject_files contains a properly marked license file in dist-info, you can omit the manual one: %license LICENSE It’s always good to verify this as follows, since this doesn’t happen for some Python build backends (like Poetry or flit-core) or in certain other cases: $ rpm -qL -p results/python3-jaraco-stream-3.0.3-1.fc39.noarch.rpm /usr/lib/python3.11/site-packages/jaraco.stream-3.0.3.dist-info/LICENSE /usr/share/licenses/python3-jaraco-stream/LICENSE ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 25 files have unknown license. Detailed output of licensecheck in /home/reviewer/2164874-python-jaraco- stream/licensecheck.txt [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.11/site- packages/jaraco(python3-jaraco) See Notes. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (based on tests passing) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK: rpmautospec [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-jaraco-stream-3.0.3-1.fc39.noarch.rpm python-jaraco-stream-3.0.3-1.fc39.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp82arg2jd')] checks: 31, packages: 2 ================ 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.6 s ================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/j/jaraco.stream/jaraco.stream-3.0.3.tar.gz : CHECKSUM(SHA256) this package : 3af4b0441090ee65bd6dde930d29f93f50c4a2fe6048e2a9d288285f5e4dc441 CHECKSUM(SHA256) upstream package : 3af4b0441090ee65bd6dde930d29f93f50c4a2fe6048e2a9d288285f5e4dc441 Requires -------- python3-jaraco-stream (rpmlib, GLIBC filtered): python(abi) python3.11dist(more-itertools) Provides -------- python3-jaraco-stream: python-jaraco-stream python3-jaraco-stream python3.11-jaraco-stream python3.11dist(jaraco-stream) python3dist(jaraco-stream) Diff spec file in url and in SRPM --------------------------------- --- /home/reviewer/2164874-python-jaraco-stream/srpm/python-jaraco-stream.spec 2023-02-16 10:06:33.145632027 -0500 +++ /home/reviewer/2164874-python-jaraco-stream/srpm-unpacked/python-jaraco-stream.spec 2023-01-25 19:00:00.000000000 -0500 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # TODO adjust once this is implemented: # https://bugzilla.redhat.com/show_bug.cgi?id=1935266 @@ -64,3 +74,4 @@ %changelog -%autochangelog +* Thu Jan 26 2023 John Doe <packager@xxxxxxxxxxx> - 3.0.3-1 +- Uncommitted changes Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2164874 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: R, Perl, PHP, fonts, Haskell, Java, C/C++, SugarActivity, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2164874 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
