[Bug 2169277] Review Request: braille-printer-app - Braille printer application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2169277

Zdenek Dohnal <zdohnal@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(benson_muite@emai
                   |                            |lplus.org)



--- Comment #13 from Zdenek Dohnal <zdohnal@xxxxxxxxxx> ---
(In reply to Benson Muite from comment #12)
> b) Without liblouis-devel buildlog contains:
> filter/liblouis1.defs.gen > filter/liblouis1.defs
> grep: /usr/share/liblouis/tables/*.utb: No such file or directory
> grep: /usr/share/liblouis/tables/*.utb: No such file or directory
> grep: /usr/share/liblouis/tables/*.ctb: No such file or directory
> grep: /usr/share/liblouis/tables/*.ctb: No such file or directory
> 
> Unclear if this affects the build though.

Aha, good catch! Those files are actually from liblouis library itself, but
since liblouis-devel requires it, the library is brought with it.

Those files are used for generating more braille drivers definitions, so if it
had been missing, some options would have not been available when Braille
drivers was generated during runtime.

I've added BuildRequires: liblouis directly, since we don't need header files
from liblouis-devel. 

> 
> 
> d) The spec file contains:
> # remove once CentOS Stream 10 is released
> Obsoletes: cups-filters-braille < 2.0
> 
> # remove once CentOS Stream 10 is released
> Provides: cups-filters-braille = %{version}-%{release}
> 
> but, this does not affect Fedora.

Thanks, that's my bad habit during adding Provides/Conflicts/Obsoletes tags - I
automatically think about migrations in CentOS Stream, but forgot about the
fact the original subpackage is not in CentOS Stream 9 :) - I rewrote the
comment to mention F39 EOL.


The newest files are uploaded.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2169277
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux