https://bugzilla.redhat.com/show_bug.cgi?id=2170204 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #12 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Package APPROVED. Conditionals: ============= - https://src.fedoraproject.org/rpms/rust-packaging/pull-request/5 to be shipped together with this - duplicate %license to be removed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License". 37 files have unknown license. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.11/site- packages/rust2rpm(rust2rpm, python3-rust2rpm), /usr/lib/python3.11/site-packages/rust2rpm/__pycache__(rust2rpm, python3-rust2rpm), /usr/lib/python3.11/site- packages/rust2rpm/templates(rust2rpm, python3-rust2rpm) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust2rpm-24.0.0-1.fc39.noarch.rpm rust2rpm-24.0.0-1.fc39.src.rpm ============================================= rpmlint session starts ============================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdqz2j9z3')] checks: 31, packages: 2 rust2rpm.noarch: W: obsolete-not-provided cargo-inspector rust2rpm.noarch: W: obsolete-not-provided python3-rust2rpm-core rust2rpm.noarch: W: no-manual-page-for-binary rust2rpm rust2rpm.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/rust2rpm/templates/plain-changelog.spec.inc /usr/lib/python3.11/site-packages/rust2rpm/templates/fedora-changelog.spec.inc:/usr/lib/python3.11/site-packages/rust2rpm/templates/mageia-changelog.spec.inc ============== 2 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.9 s ============= All OK. Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 rust2rpm.noarch: W: obsolete-not-provided cargo-inspector rust2rpm.noarch: W: obsolete-not-provided python3-rust2rpm-core rust2rpm.noarch: W: no-manual-page-for-binary rust2rpm rust2rpm.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/rust2rpm/templates/plain-changelog.spec.inc /usr/lib/python3.11/site-packages/rust2rpm/templates/fedora-changelog.spec.inc:/usr/lib/python3.11/site-packages/rust2rpm/templates/mageia-changelog.spec.inc 1 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.0 s All OK. Source checksums ---------------- https://pagure.io/fedora-rust/rust2rpm/archive/24.0.0/rust2rpm-24.0.0.tar.gz : CHECKSUM(SHA256) this package : fd47a4fa080e8dfd5f336bd823fd9dc078e73db3ac1639bebdafab24cd2b8a86 CHECKSUM(SHA256) upstream package : fd47a4fa080e8dfd5f336bd823fd9dc078e73db3ac1639bebdafab24cd2b8a86 BuildRequires ------------- (python3dist(toml) if python3-devel < 3.11) cargo pyproject-rpm-macros python3-devel python3dist(cargo2rpm) python3dist(jinja2) python3dist(packaging) python3dist(pip) >= 19 python3dist(pyparsing) python3dist(pytest) python3dist(requests) python3dist(setuptools) python3dist(termcolor) python3dist(tox) python3dist(tox-current-env) >= 0.0.6 python3dist(tqdm) python3dist(wheel) Requires -------- rust2rpm (rpmlib, GLIBC filtered): /usr/bin/python3 cargo cargo-rpm-macros cargo2rpm >= 0.1.1 python(abi) = 3.11 python3.11dist(cargo2rpm) python3.11dist(jinja2) python3.11dist(pyparsing) python3.11dist(requests) python3.11dist(termcolor) python3.11dist(tqdm) Provides -------- rust2rpm: python-rust2rpm = 24.0.0-1.fc39 python3-rust2rpm = 24.0.0-1.fc39 python3.11-rust2rpm = 24.0.0-1.fc39 python3.11dist(rust2rpm) = 24 python3dist(rust2rpm) = 24 rust2rpm = 24.0.0-1.fc39 Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17 Command line :try-fedora-review -b 2170204 -m fedora-rawhide-x86_64 -o=--addrepo=https://download.copr.fedorainfracloud.org/results/decathorpe/rust-packaging-ng/fedora-rawhide-x86_64/ Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: SugarActivity, Ruby, Perl, C/C++, Haskell, Java, PHP, fonts, R, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2170204 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
