https://bugzilla.redhat.com/show_bug.cgi?id=2168546 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxwell@xxxxxxx --- Comment #6 from Maxwell G <maxwell@xxxxxxx> --- Thanks, lichaoran, for preforming an informal review and completing the template. Here are some comments of my own: > %global srcname sphinxygen This macro is unnecessary and makes the specfile harder to read IMO. I'd use the literal values, but that's up to you. > %global forgeurl https://gitlab.com/drobilla/sphinxygen > Version: 1.0.0 > %global tag %{version} > %forgemeta I'd avoid the forge macros outside of Go and Fonts packaging. They aren't really maintained anymore. > Name: python-%{srcname} Optionally, remove %{srcname} here. > URL: %forgeurl > # Source from Pypi does not include all test files > Source0: %{forgeurl}-/archive/v%{version}/%{srcname}-v%{version}.tar.gz Optionally, remove %forgeurl here. Also, you can replace Source0 with Source. Manually numbering sources is no longer required. > BuildRequires: gzip No need to manually BuildRequire this. > BuildRequires: python3dist(setuptools) This is generated by %pyproject_buildrequires. You should remove it. > %package -n python3-%{srcname} Optionally, remove %{srcname}. > Summary: %{summary} > %{?python_provide:%python_provide python3-%{srcname}} %python_provide is deprecated and unnecessary. Let the generators handle this. > %prep > %autosetup -n %{srcname}-v%{version} Optionally, remove %{srcname}. > %build > %pyproject_wheel > #compress man page > gzip doc/%{srcname}.1 Don't compress the manpage manually. > > mkdir -p %{buildroot}%{_mandir}/man1 > install doc/%{srcname}.1.gz %{buildroot}%{_mandir}/man1/ You should preserve mtimes by using `-p`. You could use: install -Dpm 0644 doc/sphinxygen.1 -t %{builroot}%{_mandir}/man1/ > %files -n python3-%{srcname} -f %{pyproject_files} > %doc README.md NEWS > %{_bindir}/%{srcname} Optionally, remove %{srcname}. > %{_mandir}/man1/%{srcname}.1.gz Replace this with %{_mandir}/man1/%{srcname}.1* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
