Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libsvm - A Library for Support Vector Machines https://bugzilla.redhat.com/show_bug.cgi?id=254091 bugs.michael@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(bugs.michael@xxxxx| |et) | ------- Additional Comments From bugs.michael@xxxxxxx 2007-12-24 08:11 EST ------- > %define temp_file /tmp/python.ver > %define python_version %(python -V 2> %{temp_file} ; > cat %{temp_file} | awk 'BEGIN {FS= "[ .]"} > {printf("%s.%s",$2,$3)}'; rm -f %{temp_file}) This would be just a one-liner: %{!?pyver: %define pyver %(python -c 'import sys; print(sys.version[0:3])')} But that version is not needed anywhere, because: > %define libsvm_python_dir > %{_libdir}/python%{python_version}/site-packages/libsvm The Python arch-specific modules path is: %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} Use that value to build the %{python_sitearch}/libsvm path. > BuildRequires: glibc-devel Redundant. Implicit. Part of our minimal build chroot. > %build > make all DESTDIR=%{_builddir} LIBDIR=%{_libdir} "rpm --eval %{_builddir}" returns a path no %build procedure ought to see, because the value might find its way into build files. Setting it in %build is wrong. If DESTDIR can't be undefine in %build, revise your Makefile patch. > %post > /sbin/ldconfig -n %{_libdir} Please read "man ldconfig" about what option -n does. Running it like that in %post is wrong. Re: comment 18 > 3) use ldconfig scriptlet as simple as > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig Correct. > For /usr/share/libsvm/src issue maintainer commented > in %files section that its needed for developers in -devel > package. The .java files maybe. But not the binaries' C source files, headers and Makefiles. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review