[Bug 2170204] Review Request: rust2rpm - Generate RPM spec files for Rust crates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2170204



--- Comment #8 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Miro Hrončok from comment #6)
> I worry the manual `%license LICENSE` thing is now redundant, but I have not
> built the package to verify.

Indeed, the LICENSE file is now installed in both the dist-info directory *and*
%_licensedir.
I'll remove the "%license LICENSE" statement.

(In reply to Miro Hrončok from comment #7)
> OCD comment: The check bcond now disables tests, not check :)

That is true, however, it is consistent with all other Rust packages. So if we
ever need to bootstrap something, "--without check" is the canonical way to do
that.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2170204
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux