[Bug 2168255] Review Request: selint - Static code analysis of refpolicy style SELinux policy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2168255



--- Comment #15 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> BuildRequires: check-devel

I'd recommend changing this to a versioned build dependency, so you know what
it's supposed to have: "BuildRequires: pkgconfig(check) >= 0.11.0"

Changing from "check-devel" to "pkgconfig(check)" also makes the build
dependency match what the build system requests. Since the configure script is
looking for it via pkg_check_modules, that means it's using pkgconfig to find
it. So expressing the dependency in the form of a pkgconfig() dependency
ensures you're tracking the right thing.

There's more detail about this here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2168255
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux