https://bugzilla.redhat.com/show_bug.cgi?id=2170050 --- Comment #5 from Zdenek Dohnal <zdohnal@xxxxxxxxxx> --- (In reply to Petr Menšík from comment #3) > The only minor issue is missing link to upstream PR/issue above present > patch. Otherwise it seems fine. Nothing which should block the review. > The comment was added. > LT_INIT should be used instead AC_PROG_LIBTOOL in configure.ac Fixed in https://github.com/OpenPrinting/libppd/pull/8 , but didn't take it as priority for backporting. (In reply to Petr Menšík from comment #4) > Oh, noticed one thing. Shouldn't devel package has also Requires: > libcupsfilters-devel ? maybe also cups-devel, not sure about that. > > Pkg-config does not require the dependency, but header includes suggests it > is needed. > > At least <ppd/ppd.h> header includes both from cups/ and cupsfilters/ > subdirectories. That suggests they are needed anytime this devel package > should be useful. > As a minimum Recommends: should be used. Great eyes! Fixed with "Requires" on cups-devel and libcupsfilters-devel. > > Not sure if ppdc.h can be used separately and can work without > libcupsfilters-devel, do not understand they purpose enough. ppdc.h is a header file primary used for PPD compiler, which is currently shipped with CUPS, so its compilation in libppd is turned off. However the file is included in ppd/ppd-collection.cxx, which is used in libppd main library, so I'll check whether we can't separate functions needed by libppd and by ppdc. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2170050 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
