Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linux-igd - Daemon that emulates Microsoft's Internet Connection Service https://bugzilla.redhat.com/show_bug.cgi?id=426650 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-24 06:58 EST ------- For 1.0-1: * Rebuild again failed. http://koji.fedoraproject.org/koji/taskinfo?taskID=308701 Please check BuildRequires. * License tag must be "GPL+" as no version is specified on any codes in the tarball. From GPLv2 text (section 9): --------------------------------------------------------- Each version is given a distinguishing version number. If the Program specifies a version number of this License which applies to it and "any later version", you have the option of following the terms and conditions either of that version or of any later version published by the Free Software Foundation. If the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation. --------------------------------------------------------- As rebuild fails, I cannot check this package in detail (as I don't have rebuilt i386 rpm), however: * Perhaps if you try "$rpmlint linux-igd-*.i386.rpm", rpmlint complains about service-default-enabled Please check "rpmlint -I service-default-enabled" and fix this issue. * Also perhaps rpmlint complains about "conffile-without-noreplace-flag" issue. * We now recommend %defattr(-,root,root,-) * Please recheck the section "Services" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets - There must be some Requires(post) or so. - And would you explain why you don't want "service condrestart"? * For documents: - Including "LICENSE" text as %doc is rather mandatory (if it exists) - Also consider to add the following documents: --------------------------------------------------------- CHANGES TODO --------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review