https://bugzilla.redhat.com/show_bug.cgi?id=2149953 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two Quick Comments: It looks like you're adding a license file from upstream to the SRPM file, but then do nothing with it? You will probably want to do something like "cp -pav %{SOURCE1} ." at the end of %prep, and then use that file (i.e. replace the "# FIXME: no license file detected" warnings in both file lists - in the case of the subpackage for the actual binary, with `%license LICENSE`, and in the case of the "-devel" subpackage, with `%license %{crate_instdir}/LICENSE`. You will also need to determine the license of everything that's statically linked into your binaries. You can use the %cargo_license / %cargo_license_summary macros for this, i.e. adding something like this after %cargo_build: %cargo_license_summary %{cargo_license} > LICENSE.dependencies The first one prints a summary to the build log (which you can use for determining the License tag of the "-n %{crate}" subpackage), the second one writes a file into the builddir that contains a complete license breakdown for all statically linked components (which you can include with %license LICENSE.dependencies) in the subpackage for the binary, as well. You can take a look at rpm-sequoia for an example of how to handle this: https://src.fedoraproject.org/rpms/rust-rpm-sequoia/blob/rawhide/f/rust-rpm-sequoia.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2149953 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
