[Bug 2168858] Review Request: python-rapidfuzz - Rapid fuzzy string matching in Python and C++ using the Levenshtein Distance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2168858



--- Comment #1 from Karolina Surma <ksurma@xxxxxxxxxx> ---
Starting with question marks as I'm not familiar with arch packages. 

Fedora Review points out this one: 

- Header files in -devel subpackage, if present.
  Note: python3-rapidfuzz : /usr/lib64/python3.11/site-
  packages/rapidfuzz/rapidfuzz.h
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages


I don't know how to evaluate those points. 

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.


Rpmlint's output:

Rpmlint
-------
Checking: python3-rapidfuzz-2.13.7-1.fc39.x86_64.rpm
          python-rapidfuzz-debugsource-2.13.7-1.fc39.x86_64.rpm
          python-rapidfuzz-2.13.7-1.fc39.src.rpm
================================================ rpmlint session starts
===============================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp4lcznls9')]
checks: 31, packages: 3

python3-rapidfuzz.x86_64: W: files-duplicate
/usr/lib64/python3.11/site-packages/rapidfuzz/distance/LCSseq.pyi
/usr/lib64/python3.11/site-packages/rapidfuzz/distance/Hamming.pyi:/usr/lib64/python3.11/site-packages/rapidfuzz/distance/Indel.pyi
python3-rapidfuzz.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.11/site-packages/rapidfuzz/rapidfuzz.h
python-rapidfuzz.src: E: description-line-too-long RapidFuzz is a fast string
matching library for Python and C++, which is using the string similarity
python-rapidfuzz.src: E: description-line-too-long calculations from
FuzzyWuzzy. However there are a couple of aspects that set RapidFuzz apart from
FuzzyWuzzy:
python-rapidfuzz.src: E: description-line-too-long - It is MIT licensed so it
can be used whichever License you might want to choose for your project, while
you're
python-rapidfuzz.src: E: description-line-too-long - It provides many
string_metrics like hamming or jaro_winkler, which are not included in
FuzzyWuzzy
python-rapidfuzz.src: E: description-line-too-long - It is mostly written in
C++ and on top of this comes with a lot of Algorithmic improvements to make
string matching
python-rapidfuzz.src: E: description-line-too-long even faster, while still
providing the same results. For detailed benchmarks check the documentation
python3-rapidfuzz.x86_64: E: description-line-too-long RapidFuzz is a fast
string matching library for Python and C++, which is using the string
similarity
python3-rapidfuzz.x86_64: E: description-line-too-long calculations from
FuzzyWuzzy. However there are a couple of aspects that set RapidFuzz apart from
FuzzyWuzzy:
python3-rapidfuzz.x86_64: E: description-line-too-long - It is MIT licensed so
it can be used whichever License you might want to choose for your project,
while you're
python3-rapidfuzz.x86_64: E: description-line-too-long - It provides many
string_metrics like hamming or jaro_winkler, which are not included in
FuzzyWuzzy
python3-rapidfuzz.x86_64: E: description-line-too-long - It is mostly written
in C++ and on top of this comes with a lot of Algorithmic improvements to make
string matching
python3-rapidfuzz.x86_64: E: description-line-too-long even faster, while still
providing the same results. For detailed benchmarks check the documentation
================ 3 packages and 0 specfiles checked; 12 errors, 2 warnings, 12
badness; has taken 1.1 s ===============




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2

python3-rapidfuzz.x86_64: W: files-duplicate
/usr/lib64/python3.11/site-packages/rapidfuzz/distance/LCSseq.pyi
/usr/lib64/python3.11/site-packages/rapidfuzz/distance/Hamming.pyi:/usr/lib64/python3.11/site-packages/rapidfuzz/distance/Indel.pyi
python3-rapidfuzz.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.11/site-packages/rapidfuzz/rapidfuzz.h
python3-rapidfuzz.x86_64: E: description-line-too-long RapidFuzz is a fast
string matching library for Python and C++, which is using the string
similarity
python3-rapidfuzz.x86_64: E: description-line-too-long calculations from
FuzzyWuzzy. However there are a couple of aspects that set RapidFuzz apart from
FuzzyWuzzy:
python3-rapidfuzz.x86_64: E: description-line-too-long - It is MIT licensed so
it can be used whichever License you might want to choose for your project,
while you're
python3-rapidfuzz.x86_64: E: description-line-too-long - It provides many
string_metrics like hamming or jaro_winkler, which are not included in
FuzzyWuzzy
python3-rapidfuzz.x86_64: E: description-line-too-long - It is mostly written
in C++ and on top of this comes with a lot of Algorithmic improvements to make
string matching
python3-rapidfuzz.x86_64: E: description-line-too-long even faster, while still
providing the same results. For detailed benchmarks check the documentation
 2 packages and 0 specfiles checked; 6 errors, 2 warnings, 6 badness; has taken
0.3 s


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2168858
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux