https://bugzilla.redhat.com/show_bug.cgi?id=2168538 --- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Thanks for the review! (In reply to Benson Muite from comment #1) [...] > Comments: > a) Upstream project has been renamed to ReadyMedia. Should this be renamed? No. Upstream project is ReadyMedia but even they distribute minidlna as minidlna. > b) Should GPL-2.0-only also be added to the license section? Yes. > c) Can you add a license breakdown in the spec: Yes, but in a separate file. I don't want to clutter the spec. Spec URL: https://rathann.fedorapeople.org/review/minidlna/minidlna.spec SRPM URL: https://rathann.fedorapeople.org/review/minidlna/minidlna-1.3.2-3.fc38.src.rpm * Wed Feb 15 2023 Dominik Mierzejewski <dominik@xxxxxxxxxxxxxx> - 1.3.2-3 - add missing GPLv2 only to license field - add licensing breakdown -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2168538 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue