[Bug 426539] Review Request: perl-Test-YAML-Meta - Validation of the META.yml file in a distribution.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-YAML-Meta - Validation of the META.yml file in a distribution.


https://bugzilla.redhat.com/show_bug.cgi?id=426539


panemade@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade@xxxxxxxxx  2007-12-24 00:28 EST -------
Review:
+ package builds in mock (rawhide).
+ rpmlint is silent for SRPM. 
- rpmlint is NOT silent for RPM.
perl-Test-YAML-Meta.noarch: W: file-not-utf8
/usr/share/doc/perl-Test-YAML-Meta-0.06/LICENSE
==>take care to fix this issue while importing this package.
+ source files match upstream url
2f573f7cc983b6fc6509790e38cb14ed  Test-YAML-Meta-0.06.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputsPERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM"
"-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01use............ok
t/02metafiles......ok
t/03metaversion....ok
t/04metatester.....ok
t/90podtest........ok
t/91podcover.......ok
t/94metatest.......ok
All tests successful.
Files=7, Tests=166,  0 wallclock secs ( 0.22 cusr +  0.04 csys =  0.26 CPU)

+ Package  perl-Test-YAML-Meta-0.06-2.fc9 ->
  Provides: perl(Test::YAML::Meta) = 0.06 perl(Test::YAML::Meta::Version) = 0.06
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Test::Builder)
perl(Test::YAML::Meta::Version) perl(Test::YAML::Valid) perl(strict) perl(vars)
perl(warnings)

SHOULD:
  Fix rpmlint warning on SRPM before cvs import
  You can add examples directory to %doc
  

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]