[Bug 2169695] Review Request: python-datetimerange - python module python-datetimerange

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2169695



--- Comment #1 from Alfredo Moralejo <amoralej@xxxxxxxxxx> ---
Some comments:

- srpm package name should be python-datetimerange, not python-DateTimeRange
- in the summary, i'd say "Python module DateTimeRange"
- I see you are patching requirements.txt:

sed -i 's/\[datetime\]//g' requirements/requirements.txt

As we are not providing subpackage datetime in python-typepy. Note that this
package is actually using that specific functionality of typepy and
python3-typepy is not including the extra_requirements needed for it:

https://github.com/thombashi/typepy/blob/master/setup.py#L44-L48

That means this package will fail at runtime when trying to import
datetimerange

I'd propose to fix python-typepy and add the requirements for dateutil extras
explicitelly. Other alternatives would be creating subpackage
python3-typepy+dateutil or adding those runtime requirements in
python-datetimerange, although i'd say the right fix would be more in the
python-typepy side.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2169695
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux