https://bugzilla.redhat.com/show_bug.cgi?id=2169613 --- Comment #2 from Felix Wang <topazus@xxxxxxxxxxx> --- (In reply to Vasiliy Glazov from comment #1) > 1. Change licensee name. > > 2. Remove BuildRequires: moarvm > Because moarvm-devel is enough. > > 3. Remove -n rakudo-%{version} > > 4. Change make %{?_smp_mflags} to %make_build. > > 5. Use macro for directory names: > %{_bindir} instead of /usr/bin > and %{name} instead of rakudo. Thanks for taking your time to do the review. I fixed the places that need corrections. Here are the results: build: https://copr.fedorainfracloud.org/coprs/topazus/raku/build/5525362/ Spec URL: https://download.copr.fedorainfracloud.org/results/topazus/raku/fedora-rawhide-x86_64/05525362-rakudo/rakudo.spec Fedora Review: https://download.copr.fedorainfracloud.org/results/topazus/raku/fedora-rawhide-x86_64/05525362-rakudo/fedora-review/review.txt SRPM URL: https://download.copr.fedorainfracloud.org/results/topazus/raku/fedora-rawhide-x86_64/05525362-rakudo/rakudo-2022.12-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2169613 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
