[Bug 2169612] Review request: nqp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2169612

Vasiliy Glazov <vascom2@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |vascom2@xxxxxxxxx
              Flags|                            |fedora-review?
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |vascom2@xxxxxxxxx



--- Comment #1 from Vasiliy Glazov <vascom2@xxxxxxxxx> ---
1. License name must be changed to Artistic-2.0 according
https://docs.fedoraproject.org/en-US/legal/allowed-licenses/

2. Remove -n nqp-%{version} from %autosetup line.

3. make %{?_smp_mflags}
change to
%make_build

4. Need to clarify this files owning:
%dir /usr/share/nqp
/usr/share/nqp/lib/

Because /usr/share/nqp already owned by moarvm.
And you must change /usr/share to %{_datadir}


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2169612
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux