https://bugzilla.redhat.com/show_bug.cgi?id=2169238 --- Comment #3 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #2) > Nit: These should be in %check so that it's obvious they're part of package verification The guidelines state either %check or %install without preference. > Please add a trailing slash so that it's obvious the RPM that this is a directory. I'm not against this, but this seems to be a style choice rather than a guidelines question. > This means we need "Requires: hicolor-icon-theme" in the package. Added. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2169238 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
