[Bug 2169238] Review Request: whatip - Info on your IP address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2169238

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ngompa13@xxxxxxxxx



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Spec review:

> desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
> appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/%{app_id}.appdata.xml

Nit: These should be in %check so that it's obvious they're part of package
verification

> %{python3_sitelib}/%{name}

Please add a trailing slash so that it's obvious the RPM that this is a
directory.

> %{_datadir}/icons/hicolor/*/*/%{app_id}*

This means we need "Requires: hicolor-icon-theme" in the package.

> %{_datadir}/%{name}

Please add a trailing slash so that it's obvious the RPM that this is a
directory.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2169238
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux