https://bugzilla.redhat.com/show_bug.cgi?id=2167841 --- Comment #2 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- > Comments: > a) Builds on all architectures > https://copr.fedorainfracloud.org/coprs/build/5502953 > b) Can you add sed to BuildRequires Strictly speaking it's not necessary, but I'll add it. > c) The files > src/cue_parse.c > src/cue_parse.h > src/toc_parse.c > src/toc_parse.h > are GPL2 or later, update License section to indicate > GPL-2.0-only AND GPL-2.0-or-later These are bison-generated parsers, and as such fall under a GPL exception. I'll use a WITH statement here instead. > d) Check if upstream will add a SONAME Upstream is stagnant, there hasn't been a release in years, and the only expected consumer is another package from the same project. > e) To preserve timestamps use > cp -p -v include/cuetools/*.h %{buildroot}%{_includedir}/cuetools/ > instead of > cp -v include/cuetools/*.h %{buildroot}%{_includedir}/cuetools/ This was copied from libreplaygain, another library from the same project; please report this there. I'll use install instead. > f) There is another cuetools package at > https://github.com/gchudov/cuetools.net That's .NET/C#, completely unrelated to this. > g) Very similar package: > https://github.com/svend/cuetools > https://packages.fedoraproject.org/pkgs/cuetools/cuetools/ > Could this be used instead? That is the original sources from which libcuefile was forked, but the library there was treated as a convenience library (used in tree, not installed as a system library). As such, they do not conflict. This version is what musepack tools expect to use, and they have modified it somewhat to meet their specific needs. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2167841 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
