Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Math-BaseCnv - Fast functions to CoNVert between number Bases https://bugzilla.redhat.com/show_bug.cgi?id=426644 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-12-23 13:23 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 60d5fb31db63e3d7a9807b0df37c4a80 Math-BaseCnv-1.4.75O6Pbr.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/00pod.....ok t/00podc....ok t/01base....ok All tests successful. Files=3, Tests=33, 0 wallclock secs ( 0.22 cusr + 0.04 csys = 0.26 CPU) + Package perl-Math-BaseCnv-1.4.75O6Pbr-2.fc9 Provides: perl(Math::BaseCnv) = 1.4.75 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review