https://bugzilla.redhat.com/show_bug.cgi?id=2162851 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |pemensik@xxxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #1 from Petr Menšík <pemensik@xxxxxxxxxx> --- The package seems fine. I would recommend moving headers into separate subdirectory and adding -I to flags on pkgconfig file. Those files have no direct relation to symcrypt. /usr/include/resource.h file look especially generic and unrelated. But it has no conflict AFAIK. Another thing is Patch0 should be offered to upstream for inclusion. But it would have to be done a different way. Perhaps use CMake's find_library() macro and skip internal if found would be accepted. Then link to MR should be included above the patch tag. I do not think CMAKE_BUILD_TYPE=Debug should be used for a Fedora package. RelWithDebInfo would be more appropriate. We want it optimized, just not stripped. More important is not using Fedora's macros for cmake. Please use - %cmake instead of cmake .. - %cmake_build instead of make It seems upstream does not provide install target, so %cmake_install cannot be used. Add install -p parameter to keep unmodified files stable at least. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2162851 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
