[Bug 2167496] Review Request: rust-imagequant - Palette quantization library that powers pngquant and other PNG optimizers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2167496

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx
                 CC|                            |decathorpe@xxxxxxxxx
              Flags|                            |fedora-review?
         Depends On|                            |2152697



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> # -a is required here because the default feature is `threads`
> # and `threads` depends on 3 optional dependencies.
> # Optional dependencies are usually ignored by the cargo_generate_buildrequires macro
> # With -a we tell the macro to require all (there are only 3) optional dependencies
> %cargo_generate_buildrequires -a

This might fix the problem of missing BuildRequires, but it's a solution for
the wrong problem, and will result in broken packages down the line.
The "dep:foo" syntax is not yet supported by our Rust tooling (c.f.
RHBZ#2152697), and this crate will not be able to be packaged correctly until
that's done (i.e. the fact that adding the "-a" flag "fixes" the build is a
bug, and will not be required once the tooling is fixed).



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2152697
[Bug 2152697] rust2rpm / rust-packaging doesn't support Rust 1.60+ features for
optional and conditional dependencies
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2167496
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux