[Bug 2165453] Review Request: google-noto-sans-cjk-vf-fonts - Google Noto Sans CJK Variable Fonts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2165453



--- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Suggestion:
1) As per Fedora packaging guidelines this package SPEC does not follow the
Provides: tag. It should be written like 
Provides: oldpackagename = $provEVR
Obsoletes: oldpackagename < $obsEVR

You should not use Obsoleted package n-v-r to Provides: it should be providing
package n-v-r.

2) also obsoletes_version is wrong. You should put complete n-v-r in Obsoletes:
line as well, thus you should be writing
%global obsoletes_epoch_version_release 0:20220320-8

%global obsoletes_pkg()\
%define subpkgname %1\
Obsoletes:      %{subpkgname} < %{obsoletes_epoch_version_release}\
Provides:       %{subpkgname} = %{epoch}:%{version}-%{release}\

3) You can change
%define obsoletes_pkg()\
to
%global obsoletes_pkg()\

%define obsoletes_sans()\
to
%global obsoletes_sans()\


4) When I tried to open ttc files in fontforge, I am unable to open it. Is this
expected?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2165453
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux