https://bugzilla.redhat.com/show_bug.cgi?id=2156243 Troy Curtis <troy@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #3 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- Howdy Jasmin! 👋 It looks like you might be a new aspiring contributor (presuming jasmin is your FAS username), and so you are perhaps starting work following through the packaging guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/). First of all, welcome and I'm excited to see your motivation to help make Fedora better! A few helpful hints to get you started: 1. I would start by picking one or two packages, and going through the full process first. This is more a "go deep" instead of a "go wide" approach. Once you've gained some experience you'll be more prepared to contribute on other packages. 2. Note that the fedora-review tool is an excellent resource, but it is only a starting point. In particular, note how most of the items have an empty box (e.g. "[ ]"). Each of these empty boxes are there to be manually assessed by the reviewer (that you! ;) ) The main contribution of the reviewer is going through this process, and double checking the submitter's work on the packaging process. Posting the raw output without review is minimally useful. 3. While the fedora-review tool is great, it doesn't always get things right, and in particular sometimes things listed as issues actually are not. Especially as you try to build experience with packaging, it is a useful exercise to dig in to understand how you might fix the issue if you were the submitter. This could potentially really help out the submitter as well (as long as you describe your found solution in a comment), but also you might find there is actually no issue to fix. For example, I presume one of the reason this was posted was due to: ``` Issues: ======= - Dist tag is present. ``` However, in this case this is just because fedora-review doesn't have good support for `%autorelease` (well it's [fixed but not yet released](https://pagure.io/FedoraReview/issue/427)). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2156243 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
