https://bugzilla.redhat.com/show_bug.cgi?id=2166935 Jarek Prokop <jprokop@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jprokop@xxxxxxxxxx Flags| |fedora-review+ Status|NEW |ASSIGNED --- Comment #3 from Jarek Prokop <jprokop@xxxxxxxxxx> --- LGTM. Simple package, no big surprises. Mock OK, copr OK, spec is sane, license is OK, RPM is installable, simple `ruby -e 'require "redis-client"; p RedisClient'` smoke test OK, gem2rpm template was used so pretty standard. Not going to block import on this, but consider using `git -C redis-client archive ...` instead of `git clone ... && cd ...` for tests checkout. It is personally more comfortable in the update experience I had with similar packages that do not ship the test suite. Also for hiredis and toxiproxi tests we need gems of those names for the test, right? Not sure from the TODO what kind of work is needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166935 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
