[Bug 2151289] Review Request: numberstation - TOTP Authenticator application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2151289



--- Comment #13 from Vasiliy Glazov <vascom2@xxxxxxxxx> ---
1. You must explay why explicitly disable debuginfo
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages

If it is because package noarch than it is not needed. RPM will do it himself.

2. No need to describe each file and directory at %files section. You can
simplify this and use only one string with top directory. All files and
subdirectories in it will be added automatically.

4. Reporting to upstream good but until change not accepted by upstream you
must use patch in sspec file and validate this xml.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2151289
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux