https://bugzilla.redhat.com/show_bug.cgi?id=2166288 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- > b) Can a comment be added in the spec file on why the source for the tests need to be packaged? Tests are packaged in order to be able to run them later against the installed library. They will be exhibited in gating tests. I don't think this needs to be specifically documented in the spec file. There is already %description which explains what the package contains and how to use it. > c) Should upstream add a copy of GPL license as well? Upstream think it's a copy-and-paste mistake. Next release will probably change the license to LGPL. <https://gitlab.xiph.org/xiph/icecast-libigloo/-/issues/6> > d) Thanks for detailed license breakdown. The license field for the main package only contains LGPL2. Should other licenses be added? License tag always describes a content of the binary RPM package. The main binary package does not include non-LGPL files. Hence it cannot list other licenses. Compare to tests subpackage which contains tests/prng.c file, hence it lists GPL-2.0-only. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166288 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
