https://bugzilla.redhat.com/show_bug.cgi?id=2165410 Sandro Mani <manisandro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #8 from Sandro Mani <manisandro@xxxxxxxxx> --- Approved - I'd just suggest simplifying %dir %{_includedir}/catch2 %{_includedir}/catch2/*.hpp %dir %{_includedir}/catch2/benchmark %{_includedir}/catch2/benchmark/*.hpp %dir %{_includedir}/catch2/benchmark/detail %{_includedir}/catch2/benchmark/detail/*.hpp %dir %{_includedir}/catch2/generators %{_includedir}/catch2/generators/*.hpp %dir %{_includedir}/catch2/interfaces %{_includedir}/catch2/interfaces/*.hpp %dir %{_includedir}/catch2/internal %{_includedir}/catch2/internal/*.hpp %dir %{_includedir}/catch2/matchers %{_includedir}/catch2/matchers/*.hpp %dir %{_includedir}/catch2/matchers/internal %{_includedir}/catch2/matchers/internal/*.hpp %dir %{_includedir}/catch2/reporters %{_includedir}/catch2/reporters/*.hpp to just %{_includedir}/catch2/ for better readability. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165410 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
