https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #55 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> --- Hello, I'll address the review's rpmlint warnings and errors here: > janus-devel.x86_64: W: only-non-binary-in-usr-lib There are several files here that might have to be part of the main package, as stated here (from https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages): "As an additional complication, some software generates unversioned shared objects which are not intended to be used as system libraries. These files are usually plugins or modular functionality specific to an application, and are not located in the ld library paths or cache. This means that they are not located directly in /usr/lib or /usr/lib64, or in a directory listed as a library path in /etc/ld.so.conf (or an /etc/ld.so.conf.d/config file). Usually, these unversioned shared objects can be found in a dedicated subdirectory under /usr/lib or /usr/lib64 (e.g. /usr/lib/purple-2/ is the plugin directory used for libpurple applications). In these cases, the unversioned shared objects do not need to be placed in a -devel package." In this case, these, in fact, are plugins and do live in a path listed as a library path. They also live in their own subdirectory. If you agree, I am moving these to the main package. Also, I think, these warnings should be ignored. > janus-demos.noarch: W: no-documentation There is, in fact, no documentation for demos. It's just an "offline website" that shows a demonstration of the plugin's capabilities. Let me know how to proceed here. > janus-devel.x86_64: W: no-documentation Devel does have a ton of documentation but it is packaged in the "doc" sub-package. I didn't find anything in the packaging guidelines that says I should forcibly include anything in the devel sub-package. I think this message should be ignored as well. Let me know how to proceed, please. > janus-doc.noarch: W: files-duplicate /usr/share/doc/janus/html/search/variables_10.js /usr/share/doc/janus/html/search/all_10.js Indeed, I have two cases of "duplicate files" here but this documentation is generated on-the-fly by doxygen. I don't know enough doxygen as to know if I can safely remove or merge these files. Let me know how to proceed with these, please. Nothing in the packaging guidelines either. I found nothing in the packaging guidelines in regards to duplicate documentation resources. The only duplication subject I could find was in regards to bundled libraries. > janus-doc.noarch: E: file-contains-date-and-time /usr/share/doc/janus/html/recordplay.html > janus-doc.noarch: E: file-contains-current-date /usr/share/doc/janus/html/voicemail.html As mentined above, the documentation package is generated by doxygen. All files will have the current date so, IMHO, that message should be ignored. About the files containing the current date, yes, this is, also, expected. One curious thing, though. When I run rpmlint against the doc subpackage, I don't get those messages; not even with the `--strict` flag. I wonder if this message is no longer useful and the builder's rpmlint version still has it? > janus.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/janus SSL_CTX_set_cipher_list I've talked about this with upstream here: https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/YGXU4J0VAwAJ I've proposed a patch but, as said there, I am not a C developer. In any case, that conversation fell off. I'm gonna start a thread on their mailing list just about this to see if we can work it out. > janus-plugins-audiobridge.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/janus/plugins/libjanus_audiobridge.so.1.1.2 > janus-plugins-nosip.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/janus/plugins/libjanus_nosip.so.1.1.2 > janus-plugins-sip.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/janus/plugins/libjanus_sip.so.1.1.2 These I haven't mentioned, I think, to upstream. I'll see if I can get them to switch to getaddrinfo. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
