https://bugzilla.redhat.com/show_bug.cgi?id=2165410 --- Comment #2 from Sandro Mani <manisandro@xxxxxxxxx> --- Some initial comments: - I'd suggest using Source0: %{url}/archive/refs/tags/v%{version}/%{name}-%{version}.tar.gz to have the source archive filename not just be a version. - Unowned directories: %{_datadir}/%{name}/, %{_includedir}/catch2/, either add %dir %{_datadir}/%{name} %dir %{_includedir}/catch2 or list the these as %{_datadir}/%{name}/ %{_includedir}/catch2/ - Group should not be used: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165410 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
