https://bugzilla.redhat.com/show_bug.cgi?id=2165336 --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Public domain GNU General Public License, Version 1 Artistic License 2.0 Artistic License 1.0 GNU Affero General Public License v3.0", "Unknown or generated", "GNU Affero General Public License v3.0", "*No copyright* GNU Affero General Public License v3.0", "The Perl 5 License GNU General Public License, Version 2", "*No copyright* The Perl 5 License", "Academic Free License v3.0", "*No copyright* Apache License 2.0", "*No copyright* Artistic License 1.0 (Perl)", "Artistic License 2.0", "*No copyright* BSD 2-Clause with views sentence", "*No copyright* BSD 3-Clause License", "*No copyright* Boost Software License 1.0", "*No copyright* CeCILL Free Software License Agreement v2.1", "Eclipse Public License 1.0", "GNU General Public License, Version 2", "*No copyright* ISC License", "GNU Library General Public License, Version 2.0", "GNU Lesser General Public License, Version 2.1", "*No copyright* MIT License", "Mozilla Public License 1.0", "*No copyright* Mozilla Public License 1.1", "*No copyright* Mozilla Public License 2.0", "NTP License", "SIL Open Font License 1.1", "*No copyright* PostgreSQL License", "Python Software Foundation License 2.0", "Q Public License 1.0", "RealNetworks Public Source License v1.0", "*No copyright* zlib License", "Academic Free License v1.1", "Academic Free License v1.2", "Academic Free License v2.0", "Academic Free License v2.1", "Affero General Public License v1.0", "Aladdin Free Public License, Version 8", "Apache License 1.1", "*No copyright* Artistic License 1.0", "BSD 2-Clause License", "BSD 3-Clause License", "BSD 4-Clause License", "Creative Commons Attribution 1.0 Generic", "*No copyright* Creative Commons Attribution 2.0", "*No copyright* Creative Commons Attribution 2.5", "Creative Commons Attribution 3.0", "Creative Commons Attribution 4.0", "Creative Commons Attribution-NonCommercial 1.0", "*No copyright* Creative Commons Attribution-NonCommercial 2.0", "*No copyright* Creative Commons Attribution-NonCommercial 2.5", "Creative Commons Attribution-NonCommercial 3.0", "Creative Commons Attribution- NonCommercial 4.0", "Creative Commons Attribution-NoDerivs- NonCommercial 1.0", "*No copyright* Creative Commons Attribution- NonCommercial-NoDerivs 2.0", "*No copyright* Creative Commons Attribution-NonCommercial-NoDerivs 2.5", "Creative Commons Attribution-NonCommercial-NoDerivs 3.0", "Creative Commons Attribution-NonCommercial-NoDerivatives 4.0", "Creative Commons Attribution-NonCommercial-ShareAlike 1.0", "*No copyright* Creative Commons Attribution-NonCommercial-ShareAlike 2.0", "*No copyright* Creative Commons Attribution-NonCommercial-ShareAlike 2.5", "Creative Commons Attribution-NonCommercial-ShareAlike 3.0", "Creative Commons Attribution-NonCommercial-ShareAlike 4.0", "Creative Commons Attribution-NoDerivs 1.0", "*No copyright* Creative Commons Attribution-NoDerivs 2.0", "*No copyright* Creative Commons Attribution-NoDerivs 2.5", "Creative Commons Attribution-NoDerivs 3.0", "Creative Commons Attribution-NoDerivatives 4.0", "Creative Commons Attribution-ShareAlike 1.0", "*No copyright* Creative Commons Attribution-ShareAlike 2.0", "*No copyright* Creative Commons Attribution-ShareAlike 2.5", "Creative Commons Attribution-ShareAlike 3.0", "Creative Commons Attribution-ShareAlike 4.0", "*No copyright* Creative Commons CC0 1.0", "*No copyright* CeCILL Free Software License Agreement v1.0", "*No copyright* CeCILL Free Software License Agreement v1.1", "*No copyright* CeCILL Free Software License Agreement v2.0", "*No copyright* CeCILL-B Free Software License Agreement v1.0", "*No copyright* CeCILL-C Free Software License Agreement v1.0", "Cube License", "Eurosym License", "Freetype Project License", "ICU License", "ISC License", "libpng License", "CMU License", "Enlightenment License (e16)", "enna License", "*No copyright* feh License", "*No copyright* Mozilla Public License 1.0", "Mozilla Public License 2.0", "Microsoft Public License", "Microsoft Reciprocal License", "*No copyright* SIL Open Font License 1.0", "*No copyright* SIL Open Font License 1.1", "PostgreSQL License", "Python License 2.0", "SGI Free Software License B v1.0", "*No copyright* SGI Free Software License B v1.1", "Unicode Terms of Use", "Do What The Fuck You Want To Public License, Version 2", "curl License", "zlib/libpng License with Acknowledgement", "Beerware License", "Boost Software License 1.0", "BSD 1-Clause License", "Common Development and Distribution License", "GNU General Public License v3.0 or later", "*No copyright* GNU Lesser General Public License v2.1 or later", "GNU General Public License v1.0 or later", "GNU General Public License v2.0 or later", "GNU General Public License, Version 3", "GNU General Public License", "Lisp Lesser General Public License", "Mozilla Public License 1.1", "GNU General Public License, Version 2 [obsolete FSF postal address (Temple Place)]", "Adobe Glyph List License", "*No copyright* Boehm GC License", "mit_epinions", "*No copyright* Festival", "mit_osf", "libtiff License", "Standard ML of New Jersey License", "*No copyright* MIT (old)", "mit_widget", "*No copyright* NTP License (legal disclaimer)", "*No copyright* MIT (Old Style, legal disclaimer)", "*No copyright* NTP License MIT Open Group variant", "mit_openvision", "DSDP License", "*No copyright* mit_unixcrypt", "*No copyright* mit_whatever", "WordNet License", "*No copyright* mit_xfig", "*No copyright* mpich2 License", "MIT License", "GNU Affero General Public License v3.0 or later", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* Mozilla Public License 2.0 Apache License 2.0", "*No copyright* Eclipse Public License GNU General Public License v2.0 or later", "Eclipse Public License GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "GNU Library General Public License v2 or later", "GNU Lesser General Public License v2.1 or later", "OpenSSL License GNU Affero General Public License v3.0 or later", "OpenSSL License GNU General Public License v3.0 or later", "GNU Lesser General Public License, Version 2.1 GNU General Public License, Version 3", "GNU General Public License, Version 3 LGPL (v2.1 or v3)", "GNU Lesser General Public License v2.1 or later GNU General Public License v2.0 or later", "*No copyright* GNU General Public License v2.0 or later", "GNU Library General Public License v2 or later [obsolete FSF postal address (Mass Ave)]", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU General Public License v2.0 or later [mis-spelled FSF postal address (Franklin Steet)]", "Sun Industry Standards Source License v1.1 GNU Lesser General Public License, Version 2.1 [obsolete FSF postal address (Temple Place)]", "[generated file]", "FSF Unlimited License (with License Retention) [generated file]", "GNU General Public License v2.0 or later [generated file]", "FSF Unlimited License [generated file]", "*No copyright* [generated file]", "X11 License [generated file]", "Academic Free License v2.0 GNU Library General Public License v2 or later", "*No copyright* GNU Affero General Public License v3.0 or later", "Apache License 2.0", "*No copyright* Apache License (v2.0) or GNU General Public License (v2)", "Apache License (v2.0) or MIT license", "Apache License (v2.0) or GNU General Public License (v2)", "Creative Commons Attribution-ShareAlike 2.0", "*No copyright* Creative Commons Attribution-ShareAlike 3.0", "*No copyright* GNU Lesser General Public License", "GNU Lesser General Public License", "GNU Lesser General Public License, Version 2.1 [obsolete FSF postal address (Temple Place)]", "GNU Lesser General Public License, Version 3", "GNU Library General Public License v2 or later [obsolete FSF postal address (Temple Place)]", "LGPL (v2.1 or v3)", "Boehm GC License", "MIT (old)", "mit_oldstyle_permission", "Mozilla Public License 1.1 GNU General Public License v2.0 or later GNU General Public License (v2 or later) or GNU Lesser General Public License (v2.1 or later)", "NTP License (legal disclaimer) [generated file]", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "Do What The Fuck You Want To Public License, Version 1". 46 files have unknown license. Detailed output of licensecheck in /home/fedora/2165336-perl-String- License/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/String(perl-String-CamelCase, perl- String-Interpolate-Named, perl-String-Trim, perl-String-Dirify, perl- String-Random, perl-String-Errf, perl-String-Formatter, perl-String- Escape, perl-String-Format, perl-String-RewritePrefix, perl-String- Truncate, perl-String-ToIdentifier-EN, perl-String-ShellQuote, perl- String-Trim-More, perl-String-Copyright, perl-String-Util, perl- String-Print, perl-String-TtyLength, perl-String-Flogger, perl-String- Diff) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-String-License-0.0.4-1.fc38.noarch.rpm perl-String-License-0.0.4-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnqr9quuy')] checks: 31, packages: 2 perl-String-License.noarch: W: invalid-license AGPL-3.0 perl-String-License.src: W: invalid-license AGPL-3.0 perl-String-License.noarch: E: description-line-too-long String::License identifies license statements in a string and serializes them in a normalized format. perl-String-License.src: E: description-line-too-long String::License identifies license statements in a string and serializes them in a normalized format. 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 2 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 perl-String-License.noarch: W: invalid-license AGPL-3.0 perl-String-License.noarch: E: description-line-too-long String::License identifies license statements in a string and serializes them in a normalized format. 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.0 s Source checksums ---------------- https://cpan.metacpan.org/authors/id/J/JO/JONASS/String-License-v0.0.4.tar.gz : CHECKSUM(SHA256) this package : 2336711d810f8100121d28c4b70e22f63760553d6186a8c52c2a4b88f883042d CHECKSUM(SHA256) upstream package : 2336711d810f8100121d28c4b70e22f63760553d6186a8c52c2a4b88f883042d Requires -------- perl-String-License (rpmlib, GLIBC filtered): perl(:VERSION) perl(Array::IntSpan) perl(Carp) perl(Feature::Compat::Class) perl(List::SomeUtils) perl(Log::Any) perl(Regexp::Pattern) perl(Regexp::Pattern::License) perl(Scalar::Util) perl(String::License::Naming::Custom) perl(String::License::Naming::SPDX) perl(namespace::clean) perl(utf8) perl(warnings) perl-libs Provides -------- perl-String-License: perl(String::License) perl(String::License::Naming) perl(String::License::Naming::Custom) perl(String::License::Naming::SPDX) perl-String-License Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2165336 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Perl, Generic Disabled plugins: fonts, SugarActivity, R, Ocaml, Java, C/C++, PHP, Python, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) License should be AGPL-3.0-or-later see the README b) Maybe helpful to document what dependencies are used for, for example see https://src.fedoraproject.org/rpms/perl-Software-License/blob/rawhide/f/perl-Software-License.spec c) Put description on two lines -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165336 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
