[Bug 2164882] Review Request: python3-pyrate_limiter - The request rate limiter using Leaky-bucket algorithm.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2164882



--- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
This is why I didn’t run the tests in parallel:

# Upstream runs tests in parallel, but we find there are race conditions;
# therefore, we do not need: pytest-xdist

I thought that fixed it, but based on what you’re seeing, there’s a real
upstream bug that this test is revealing.

I thought about reporting it upstream, but there were dependency issues in PyPI
land and I couldn’t run the tests the way uptstream does. It seems like that’s
fixed today, and I can try it outside of the RPM build.

For now, I would say you can remove

  #
  # Upstream runs tests in parallel, but we find there are race conditions;
  # therefore, we do not need: pytest-xdist

and add

  # pytest-xdist = "^2.5.0"
  BuildRequires:  %{py3_dist pytest-xdist} >= 0.12

and change

  %pytest -v ${ignore-}

to

  # Flaky failures in test_concurrency
  # https://github.com/vutran1710/PyrateLimiter/issues/94
  k="${k-}${k+ and }not test_concurrency[ProcessPoolExecutor-SQLiteBucket]
  %pytest -v -n auto ${ignore-} -k "${k-}"


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2164882
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux