[Bug 2161095] Review Request: python-ffmpeg-python - Python bindings for FFmpeg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2161095



--- Comment #16 from Ondrej Mosnáček <omosnacek@xxxxxxxxx> ---
(In reply to Neal Gompa from comment #14)
> Review notes:
> 
> * Package follows general packaging guidelines
> * Package follows Python packaging guidelines
> * Package builds and installs
> * No serious issues from rpmlint

Thanks for the review!

> Something to consider: maybe rework the upstream tests to use Free codecs
> like VP9 and Opus on WebM rather than H264 and AAC on MP4. That way you can
> turn them on later. :)

Yeah, I do tend to tinker with tests, so it's likely I will get to that
eventually :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2161095
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux