https://bugzilla.redhat.com/show_bug.cgi?id=2162694 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |mhroncok@xxxxxxxxxx Status|NEW |ASSIGNED --- Comment #12 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- # Originally bundled libraries Requires: fontawesome-fonts Requires: fontawesome-fonts-web Nitpick: The comment should probably say "fonts" rather than "libraries" now. ---------- A very small nitpick: %generate_buildrequires could use an extra empty line above it to follow the convention of the rest of the specfile. ---------- What is the license of the bundled JavaScript libraries? It should probably be included in the License tag (I know it wasn't done in the notebook package) :( See for example https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2162694-python-nbclassic/fedora-rawhide-x86_64/05322649-python-nbclassic/fedora-review/licensecheck.txt ---------- Fedora-Review complains: - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. This is correct, please run desktop-file-validate ...desktop in %check, as the installation is done by %pyproject_install. python-notebook has: BuildRequires: desktop-file-utils ... %check ... desktop-file-validate %{buildroot}%{_datadir}/applications/jupyter-notebook.desktop ---------- rpmlint complains: python3-nbclassic.noarch: E: zero-length /usr/lib/python3.11/site-packages/nbclassic/bundler/tests/resources/subdir/subsubdir/.gitkeep python3-nbclassic.noarch: W: hidden-file-or-dir /usr/lib/python3.11/site-packages/nbclassic/bundler/tests/resources/subdir/subsubdir/.gitkeep python3-nbclassic.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/nbclassic/bundler/tests/resources/subdir/test_file.txt /usr/lib/python3.11/site-packages/nbclassic/bundler/tests/resources/another_subdir/test_file.txt I guess the nbclassic/bundler/tests folder would also benefit from being removed entirely. There might be others. python-notebook has: # Remove packaged tests rm -rv $(find %{buildroot}%{python3_sitelib}/notebook -type d -name tests) --------- Curiosity: The package requires (python3.11dist(jupyter-server) >= 1.17 with python3.11dist(jupyter-server) >= 1.8) I found that a bit odd as 1.8 > 1.17 anyway. Looks like an upstream oversight. https://github.com/jupyter/nbclassic/pull/208 (No need to change the package, just heads up.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2162694 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
