Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: quesoglc - The OpenGL Character Renderer https://bugzilla.redhat.com/show_bug.cgi?id=407581 ------- Additional Comments From karlikt@xxxxxxxxx 2007-12-22 14:37 EST ------- (In reply to comment #1) > For 0.6.5-1: > > * Possibly missing BuildRequires > From: > http://koji.fedoraproject.org/koji/taskinfo?taskID=282900 > http://koji.fedoraproject.org/koji/getfile?taskID=282900&name=build.log > --------------------------------------------------------- > 239 checking for FRIBIDI... no > 240 checking for fribidi_log2vis in -lfribidi... no > > 249 checking GL/glew.h usability... no > 250 checking GL/glew.h presence... no > 251 checking for GL/glew.h... no > 252 checking for glewContextInit in -lGLEW... no > 253 configure: GLEW will be built and embedded > > 258 checking for IceConnectionNumber in -lICE... no > 259 checking for GLUT library... no > 260 configure: WARNING: The GLUT library could not be found : example > programs and some tests will not be built > --------------------------------------------------------- > - fribidi-devel, glew-devel, libICE-devel are all available > on Fedora. > - And perhaps the result of line 259 is not what you expect. I hope it is fixed :) I removed glew headers from tarball and patch sources. > * dependency for -devel package > - %_includedir/GL/glc.h contains > --------------------------------------------------------- > 93 #if defined __APPLE__ && defined __MACH__ > 94 #include <OpenGL/gl.h> > 95 #else > 96 #include <GL/gl.h> > 97 #endif > --------------------------------------------------------- > This means quesoglc-devel requires mesa-libGL-devel. > ! Note: > For (Build)Requires, it is better to use > "(Build)Requires: libGL-devel" rather than mesa-libGL-devel. Added/Changed > * %check > - This tarball contains tests/ directory. If some test programs > can be executed, please create %check section and execute > some test programs there. Make runs all tests so I cannot see any sense to run it again in %check > * Encodings > - The following documents are not encoded in UTF-8. Please > change to UTF-8. > --------------------------------------------------------- > THANKS > --------------------------------------------------------- file returns me "/usr/share/doc/quesoglc-0.6.5/THANKS: UTF-8 Unicode English text" > * Documents > - Maybe files under docs/ or examples useful as %doc ? Added html generated by doxygen New files: http://karlik.nonlogic.org/quesoglc/quesoglc.spec http://karlik.nonlogic.org/quesoglc/quesoglc-0.6.5-2.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review