https://bugzilla.redhat.com/show_bug.cgi?id=2161518 --- Comment #33 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Miro Hrončok from comment #31) > Fabio, should we add RUSTFLAGS="%build_rustflags" to %py3_build and > %pyproject_wheel? Should we add it to %set_build_flags? (Not a blocker for > this review.) Probably to %set_build_flags ... more and more non-Rust projects are starting to include Rust code, so that's likely the best place for it. That would mean the definition would need to move from rust-packaging to redhat-rpm-config? Side note: You'll probably want to fix the License tag of the python3-y-py subpackage, as well. It contains a statically linked Rust binary, with components under many different licenses. Most dependencies are either MIT or "MIT OR Apache-2.0", but notably pyo3 itself is Apache-2.0 only, so just having python3-y-py subpackage inherit "MIT" is wrong. (And there's likely components under other licenses involved, as well.) You should be able to use the %cargo_license macro to generate a list of statically linked components and their licenses (or %cargo_license_summary prints only the license summary, which is more useful for determining the License tag). See https://src.fedoraproject.org/rpms/rust-rpm-sequoia/blob/rawhide/f/rust-rpm-sequoia.spec#_64 for example usage in a Rust package that will be installed on every Fedora 38 system. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161518 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
