https://bugzilla.redhat.com/show_bug.cgi?id=2161518 --- Comment #13 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Miro Hrončok from comment #12) Sorry for the drive-by comment - I wanted to spend more time on helping to package this, but university stuff got in the way. > Spec sanity > =========== > > > %global debug_package %{nil} > > I would add a comment saying this is because of Rust. For an average Python > packager it might not be obvious. > > Note that python-cryptography does not have this. This looks fishy. Rust binaries should have valid debug symbols - (i.e. the .so file in this package). If removing this line breaks build of the package, then something is going wrong with setting Rust compiler flags. This might happen if you don't call `%cargo_prep` correctly, or if upstream Cargo.toml specifies to build without debuginfo - but this is not the case for this project. > > ExclusiveArch: %{rust_arches} > > This is no longer required or mentioned in the Rust packaging guidelines. Correct. Since all Fedora architectures now need support for Rust by definition (because the GPG backend for RPM itself is now Rust based), the ExclusiveArch is now basically a noop. c.f. https://pagure.io/packaging-committee/pull-request/1222 > > url = https://github.com/y-crdt/ypy > > Suggestion: url = %{url} > > > > setup_requires = setuptools-rust > > python_requires = >=3.6 > > Is either of these actually required to build the package? I assume so. `setup.py` imports setuptools_rust, doesn't it? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161518 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
