https://bugzilla.redhat.com/show_bug.cgi?id=2152757 Neil Hanlon <neil@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(neil@xxxxxxxx) |needinfo?(michel@michel-slm | |.name) --- Comment #3 from Neil Hanlon <neil@xxxxxxxx> --- (In reply to Michel Alexandre Salim from comment #2) > This mostly looks good. Some issues (easily fixable): > > - the release tag (0) does not match the changelog (1). Since the change to > use rpmautospec by default is accepted recently > (https://fedoraproject.org/wiki/Changes/Rpmautospec_by_Default), just use > that: https://docs.pagure.org/Fedora-Infra.rpmautospec/index.html > > - this won't work without systemd installed, but the automatic dependency > generator will only generate Python dependencies. You'd want to manually > `Require: systemd` > > - the project does not come with any tests, so you probably want to at least > add some smoke tests - you're using the new Python %pyproject* macros, so > add this (normally after the %install section): > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #pyproject_check_import > > %check > %pyproject_check_import Thank you! I have made the changes as requested. Spec URL: https://git.shrug.pw/neil/python-sdnotify/src/branch/rawhide/python-sdnotify.spec Srpm URL: https://git.shrug.pw/api/packages/neil/generic/python-sdnotify/0.3.2/python-sdnotify-0.3.2-1.fc37.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2152757 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
