https://bugzilla.redhat.com/show_bug.cgi?id=2160509 Jonathan Wright <jonathan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(carl@xxxxxxxxxx) --- Comment #9 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- (In reply to Carl George 🤠 from comment #8) > Optional suggestion, use the PyPI tarball instead of the GitLab one. This > is not required by the guidelines, but I believe most Python packagers tend > to stick with PyPI tarballs unless it is missing tests or other necessary > files. > > -Source: > https://gitlab.com/dslackw/colored/-/archive/%{version}/colored-%{version}. > tar.gz > +Source: %{pypi_source colored} > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_source_files_from_pypi > I tend to go straight for GH to avoid such issues altogether. I'd prefer to stick to GH but will happily change it of course if policy ever changes (or later on it seems like upstream maintains releases on PyPi better). > > There is a build requirement for pytest, but it is not used to run the test, > so it should be removed. > > -# for tests > -BuildRequires: python3-pytest Already removed in my local copy. Looks like I uploaded a slightly outdated one here by mistake. > Upstream's TravisCI config claims to run nosetests, but none of the files in > the tests directory contain valid unit tests. They instead appear to be > scripts to run manually and visually compare the color output. I can see > the only thing is %check is an import test. I agree with that approach, but > it would also be useful to add a comment about why the upstream tests can't > be run. Added a note. > The LICENSE.txt file is properly picked up by the Python metadata, so > listing it explicitly in %files produces a duplicate. The explicit listing > should be removed to avoid this. > > -%license LICENSE.txt Good catch, fixed in my local copy. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2160509 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
