[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2163486



--- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Spec review:

> %global rpm_macros_dir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || d=%{_sysconfdir}/rpm; echo $d)

Drop this to just use "%{_rpmmacrodir}", since it's supported on all Fedora and
EPEL branches.

> %if 0%{?rhel} == 7
> BuildRequires: devtoolset-7-toolchain
> %endif

We're not supporting Qt6 on anything lower than EPEL 9, so we should be able to
drop any logic for RHEL < 9.

> %if 0%{?fedora} > 35 || 0%{?epel} > 9
> %filetriggerin -- %{_datadir}/hunspell
> %else
> %filetriggerin -- %{_datadir}/myspell
> %endif

This should be flipped:

%if 0%{?rhel} && 0%{?rhel} < 10
%filetriggerin -- %{_datadir}/myspell
%else
%filetriggerin -- %{_datadir}/hunspell
%endif


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2163486
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux