Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fmt-ptrn - A simple template system https://bugzilla.redhat.com/show_bug.cgi?id=250040 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-22 08:21 EST ------- For 1.3.12-1: * License - License tag must be "GPLv2+". * Timestamps - Please use ----------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ----------------------------------------------------- to keep timestamps on installed files. While sometimes this does not work, this method usually works on recent Makefiles. * %defattr - Please unify to %defattr(-,root,root,-) * undefined-non-weak-symbol rpmlint - From "$ rpmlint fmt-ptrn-java": ------------------------------------------------------ fmt-ptrn-java.i386: W: undefined-non-weak-symbol /usr/lib/libnewfmt-ptrnjni.so.1.3.12 fmt_ptrn_get_keys fmt-ptrn-java.i386: W: undefined-non-weak-symbol /usr/lib/libnewfmt-ptrnjni.so.1.3.12 fmt_ptrn_init fmt-ptrn-java.i386: W: undefined-non-weak-symbol /usr/lib/libnewfmt-ptrnjni.so.1.3.12 fmt_ptrn_close ------------------------------------------------------ Please fix this (perhaps linking against libnewfmt-ptrn.so should fix this issue) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review