https://bugzilla.redhat.com/show_bug.cgi?id=2160996 --- Comment #26 from Arthur Bols <arthur@xxxxxxxx> --- Sorry for the delay, I've been busy studying. I think you missed my last comment. For generating the man pages, you shouldn't need --no-discard-error. It does only fail because of the missing library, so you'll have to add `LD_LIBRARY_PATH` (see the patch in the next comment). The symlinks are also not necessary, so they may be removed as well. (`man draco_encoder` and `man draco_encoder-1.5.5` both work fine) Since the tests are now working, you can remove the gtest macro, but you can keep it if you want. Finally, there is an rpmlint error: W: mixed-use-of-spaces-and-tabs (spaces: line 19, tab: line 2) I believe everything else looks good! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2160996 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
