Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used https://bugzilla.redhat.com/show_bug.cgi?id=426530 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-12-21 23:18 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url afbabdb638d6c37b8dd31adb6544fee4 Module-ExtractUse-0.22.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/01_load.................ok t/10_basic................ok t/20_parse_self...........ok t/21_comment..............ok t/22_eval.................ok t/23_universal_require....ok t/80_failing..............skipped all skipped: parser is known to not catch those t/99_pod..................ok t/99_pod_coverage.........ok All tests successful, 1 test skipped. Files=9, Tests=84, 2 wallclock secs ( 1.79 cusr + 0.10 csys = 1.89 CPU) + Package perl-Module-ExtractUse-0.22-1.fc9 -> Provides: perl(Module::ExtractUse) perl(Module::ExtractUse::Grammar) perl(Parse::RecDescent::Module::ExtractUse::Grammar) Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Module::ExtractUse::Grammar) perl(Parse::RecDescent) perl(Pod::Strip) perl(strict) perl(vars) perl(version) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review