Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Array-Diff - Diff two arrays https://bugzilla.redhat.com/show_bug.cgi?id=426529 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-12-21 22:57 EST ------- Review: + package builds in mock (rawhide). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7c08993e1d15dfae959b706db23f5a65 Array-Diff-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs + ./Build test t/001_load...........ok t/002_pod............ok t/003_podcoverage....ok t/004_diff...........ok All tests successful. Files=4, Tests=12, 0 wallclock secs ( 0.30 cusr + 0.04 csys = 0.34 CPU) + Package perl-Array-Diff-0.04-2.fc9 Provides: perl(Array::Diff) = 0.04 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review