[Bug 2161003] Review Request: pyjwkest - Python implementation of JWT, JWE, JWS and JWK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2161003



--- Comment #3 from lichaoran <pkwarcraft@xxxxxxxxx> ---
Hi @Jakub Kadlčík

> Can you please update the summary and put the package summary instead
> of "dependency of pyoidc library"?

Already done.

> I guess that's an autogenerated comment telling you to check if the
> ASL is a correct license name according to Fedora guidelines. Please
> do so :-)

Already done.

> This is up to you, I don't see it as a blocker but I am confused where
> the source code lives. Because the PyPI page doesn't show any project
> homepage.

> I think it is this project?
> https://github.com/IdentityPython/pyjwkest

> The homepage URL was added in
> https://github.com/IdentityPython/pyjwkest/commit/dde43072349917ba1f94c8962fe19e2b77896115

> but there is a total mess in versions. The last release on GitHub is
> 1.4.0, the version on PyPI says 1.4.2, and in src/jwkest/__init__.py
> there is 1.4.3 . Can you please ask/help the maintainer to sort this out?

For now i can't find the maintainer, contacted roland/roland@xxxxxxxxxxxx but
he did not do the maintaince job for a while.
I think the pypi latest version 1.4.2 is relate to
https://github.com/IdentityPython/pyjwkest/commit/f0be3f5a5630a64b1c4cd6296a663935edbcb00f,
because the pypi latest release date is alse the same day, so i guess the
latest codebase is not in pypi but 1.4.2 is general avaliable.

> Can you please write two or three sentences about the package and
> then remove the comment?

Done.

> As the comment says, '*' is not allowed for official Fedora
> packages. Instead, you should change it to the package name. If you do
> `import foo` to use the package, then the value is 'foo'.

Done

> The fedora-review tool also found this error. Your spec should be named
> python-pyjwkest.spec

Done and modified the origin request body.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2161003
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux