https://bugzilla.redhat.com/show_bug.cgi?id=2041917 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx --- Comment #8 from Petr Menšík <pemensik@xxxxxxxxxx> --- Note: reviews are usually processed by automated tool fedora-review. That uses Spec URL: and SRPM URL: lines to obtain sources and attempt builds on them. These should lead to permanent store, which would remain accessible until the review is passed. Unfortunately scratch builds do not work this way, their built artifacts are deleted after few days. Use fedorapeople.org server to store your srpm if you do not have better place. It is not clear where I could find the most recent srpm file. Because you use additional sources, spectool -g *.spec cannot download they just from provided spec file. Please update srpm to match your latest changes. Are URLs in comment #0 still valid and contain the latest source to review? Fedora 34 tag is suscpicious. Please add new comment with links to working files, which do not get autodeleted after 3 days. Scratch builds won't work, sorry. (In reply to Dorinda from comment #6) > > These are in v0.1 tarball now, aren't they? > > Yes those sources are in v0.1 > > > I think there's a bug in upstream's meson files as they don't appear to check for rapidjson? > > Thanks for that highlight, it appear that the person that added rapidjson > dependency in makefile and cmake didn't setup the meson build system for > this yet. ref- https://github.com/mikesart/gpuvis/pull/64 > so I've sent a fix upstream. applied patches to spec file. It is a good practice to include such changes in Patch1: links and ideally provide link to its pull request in comment above the patch. Do not see that in linked spec. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2041917 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
