[Bug 2158678] Review Request: libcamera-apps - A small suite of libcamera-based apps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2158678

Petr Menšík <pemensik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pemensik@xxxxxxxxxx
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Petr Menšík <pemensik@xxxxxxxxxx> ---
This package contains a lot of lib*.so shared libraries used by executables,
which lack soname versions [1]. They are required by packaging guidelines.
Those libraries are used at link time as a normal library, not as plugins
loaded runtime.

rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libcamera_app.so
rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libencoders.so
rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libimages.so
rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/liboutputs.so
rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libpost_processing_stages.so
rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libpreview.so

Such format is usually provided by *-devel subpackages, but this package does
not have such thing.

I think they are supposed to be internal for the program and they should be
placed into %{_libdir}/%{name} with using rpath for this case [2].
It seems those libraries are not meant to be reused by any other tools
directly, because no -devel headers allows linking to them. It seems those
names do not conflicts with any existing packages now, but those names are not
specialized enough. I think moving them to to application specific subdirectory
is desireable to avoid future conflicts.

[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning
[2]
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_rpath_for_internal_libraries


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux