https://bugzilla.redhat.com/show_bug.cgi?id=2153697 --- Comment #4 from Lumír Balhar <lbalhar@xxxxxxxxxx> --- Thanks for the review! (In reply to Miro Hrončok from comment #3) > > Source: https://github.com/y-crdt/y-crdt/blob/main/LICENSE > > Could you please us a link that 1) is tagged with the appropriate version 2) > leads to the file and not a HTML page? > > This should do: > https://github.com/y-crdt/y-crdt/raw/release-v%{version}/LICENSE > > See from the fedora-review output: > > https://github.com/y-crdt/y-crdt/blob/main/LICENSE : > CHECKSUM(SHA256) this package : > c01414e4affff31246bfe5c8a2c5851364888e56069432839bd7543b9c14d3e8 > CHECKSUM(SHA256) upstream package : > f1811cce5805b547f8ee9ce44c98a004e7038ccad2b1c645f74c9c3a45973cac Fixed. > > > rust-lib0-devel.noarch: W: no-documentation > > Should there be a %doc README in this package? There is no readme file in the lib0 folder and there is only one sentence about lib0 in the main project readme. Also, the description at https://crates.io/crates/lib0 is empty. > > rust-lib0-devel.noarch: W: files-duplicate /usr/share/licenses/rust-lib0-devel/LICENSE /usr/share/cargo/registry/lib0-0.12.2/LICENSE > > Is it necessary to have %license LICENSE in the devel package when the file > is already in? (Although it is not marked as %license, so this is likely an > issue with rust2rpm. AFAIK this is a common issue in rust packages. I saw this error many times. My guess is that it's better to have it twice to mark it properly as a license file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2153697 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
