https://bugzilla.redhat.com/show_bug.cgi?id=2161518 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- 1) I worry about the bundling. Apparently you MUST package the rust deps in versions that work. You can also package pyo3-0.16.5 compact package. https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_bundled_dependencies """For Rust, this means that packages MUST NOT use dependencies from a "vendor tarball" (e.g. created by running cargo vendor), but package all library dependencies separately.""" Apparently, "the thing is not compatible with the latest versions" is not an approved reason to bundle Rust crates. If you want to bundle I guess you'll need an exception from FPC or Rust SIG, I cannot grant it myself. 2) "# This archive can be generated by update-vendored-tarball.sh" Could you please include this script as a source? In the spirit of https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code (This is moot if bundling is removed.) 3) Source: y_py-%{version}-vendor.tar.gz You don't enumerate sources yet you use %{SOURCE1} in the spec. I find that a bit confusing, WDYT? 4) The License tag MUST use SPDX expressions, i.e. capital "AND": https://docs.fedoraproject.org/en-US/legal/license-field/#_conjunctive_and_licensing 5) The License tag is surprisingly simple and the license comment only mentions direct dependencies. This bundles 51 crates and all of their licenses need to be listed and reflected in the license tag. Unfortunately, this is true also if you don't bundle, as Rust builds everything statically anyway: https://docs.fedoraproject.org/en-US/legal/license-field/#_rust_packages 6) url = https://github.com/y-crdt/ypy Tip: Use url = %{url}. 7) .cargo/config I don't understand this file. Maybe add a comment that it is inspired by %%cargo_prep from RHEL? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161518 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
