https://bugzilla.redhat.com/show_bug.cgi?id=2160996 --- Comment #10 from Arthur Bols <arthur@xxxxxxxx> --- Thanks for the changes! - I noticed you've added this macro. Does this do anything? The only reference I could find was a closed PR. %global __cmake_builder ninja - As Ben pointed earlier, it would be best to remove the docs/assets directory, as it contains precompiled CSS and JavaScript. (In reply to Luya Tshimbalanga from comment #8) > The linked guideline failed to clarify about the proper use of "help2man" > command in the spec file. I commented out these line for the time until a > proper solution occurs. You can use it like this: mkdir -p %{buildroot}%{_mandir}/man1 help2man -N -o %{buildroot}%{_mandir}/man1/%{name}_decoder.1 %{buildroot}/%{_bindir}/%{name}_decoder help2man -N -o %{buildroot}%{_mandir}/man1/%{name}_encoder.1 %{buildroot}/%{_bindir}/%{name}_encoder *snip* %{_mandir}/man1/%{name}_decoder.1* %{_mandir}/man1/%{name}_encoder.1* > > > > - missing %check > > Please check if it is feasible to compile and run the tests > > > > %ctest applied on %check line. Sadly this doesn't work: + /usr/bin/ctest --test-dir redhat-linux-build --output-on-failure --force-new-ctest-process -j8 Internal ctest changing into directory: /builddir/build/BUILD/draco-1.5.5/redhat-linux-build Test project /builddir/build/BUILD/draco-1.5.5/redhat-linux-build No tests were found!!! You will have to set -DDRACO_TESTS=ON during %build to compile the tests, but this won't work by itself. It tries to find the googletest submodule, which isn't included in the tarball. Maybe this is a trivial fix, so it would be great if you could look into it further! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2160996 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
